Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds validation to webform email configuration #6

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Adds validation to webform email configuration #6

merged 5 commits into from
Sep 7, 2023

Conversation

nicksantamaria
Copy link
Contributor

@nicksantamaria nicksantamaria commented Aug 7, 2023 •
edited
Loading

Motivation

This PR aims to prevent webform emails being configured incorrectly.

Changes

The following apply to the From, Sender, and Return-path configuration form elements.

  • Removes as many invalid options as possible.
  • Adds validation to prevent specifying custom values that are invalid (this is due to webform enforcing the presence of an "other" select option).

@nicksantamaria nicksantamaria requested a review from GROwen August 7, 2023 06:08
@nicksantamaria nicksantamaria merged commit aee322d into main Sep 7, 2023
@nicksantamaria nicksantamaria deleted the feature/webform-mail-whitelist branch September 7, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GROwen GROwen GROwen approved these changes

@anthony-malkoun anthony-malkoun Awaiting requested review from anthony-malkoun

@vincent-gao vincent-gao Awaiting requested review from vincent-gao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicksantamaria @GROwen