Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canton display fixes #60

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Canton display fixes #60

merged 4 commits into from
Feb 8, 2022

Conversation

nkcr
Copy link
Member

@nkcr nkcr commented Feb 7, 2022

+ other fixes. See commits.

@nkcr nkcr requested a review from khcr February 7, 2022 20:52
@nkcr nkcr self-assigned this Feb 7, 2022
@@ -4,7 +4,7 @@ export default class extends ListController {
static targets = [...ListController.targets, "itemTemplate", "title", "themes", "link"];

updateItems(items) {
if (items.length < 10) {
if (items.length < 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be simply removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, forgot to undo this change.

@nkcr nkcr merged commit 61dbc36 into master Feb 8, 2022
@nkcr nkcr deleted the canton-display-fixes branch February 8, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants