Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests for the cards_update check #54

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Adds tests for the cards_update check #54

merged 1 commit into from
Dec 30, 2021

Conversation

nkcr
Copy link
Member

@nkcr nkcr commented Dec 30, 2021

No description provided.

@nkcr nkcr added the V2 About the V2 migration label Dec 30, 2021
@nkcr nkcr requested a review from khcr December 30, 2021 11:35
@nkcr nkcr self-assigned this Dec 30, 2021
khcr
khcr approved these changes Dec 30, 2021
View reviewed changes
lib/tasks/cards_update_check.rake Outdated
if step == 4
# => To be implemented in model
card.update_attribute(:validity, :disabled)
p "step: #{step}, days_from_update: #{days_from_update}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that print necessary ?

@nkcr nkcr force-pushed the v2/cards-update-check-tests branch from fff2037 to 04265d3 Compare December 30, 2021 11:46
@nkcr nkcr merged commit a3d5a47 into v2/cards-update-check Dec 30, 2021
@nkcr nkcr deleted the v2/cards-update-check-tests branch December 30, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khcr khcr khcr approved these changes

Assignees

@nkcr nkcr

Labels
V2 About the V2 migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcr @khcr