feat: Add Windows Calculator Integration and Tests #97

theijhay · 2025-02-01T23:32:19Z

Description:
This PR introduces the following changes:

Windows Calculator Integration:
- Configured OpenAppTransaction to launch the Windows Calculator using WinAppDriver.
- Configured CloseAppTransaction to close the Windows Calculator.
Calculator Transactions:
- Created CalculatorTransactions class to perform calculator operations, click number buttons, and extract the result.
- Added logging and error handling to the methods.
Tests:
- Created TestCalculator class to test the Windows Calculator integration.
- The tests include performing an addition operation and validating the result.

Changes:

setup.py: Added OpenAppTransaction and CloseAppTransaction classes.
calculator.py: Added CalculatorTransactions class with logging and error handling.
test_calculator.py: Added TestCalculator class with addition test.

…ainability

…eadability Refactor CalculatorTransactions to add logging and error handling Update test_calculator.py to pass driver object to OpenAppTransaction and CloseAppTransaction

…eadability

…tion class

douglasdcm

Thanks the PR. Fundamental issues are present in the implementation. Check the examples in the tutorial to get more details, please.

examples/windows_desktop/winappdriver/calculator.py

examples/windows_desktop/winappdriver/setup.py

examples/windows_desktop/winappdriver/test_calculator.py

examples/windows_desktop/winappdriver/calculator.py

* Add pre-commit configuration * test * Add black workflow * Formatting the entire code * Set line length

…ansactions

douglasdcm

Checks failing. I will wait them be fixed before perform a new review

…ouglasdcm#92) * `Implement AENA flight data scraper using Selenium and BeautifulSoup` **Description:** - Added web scraping functionality to collect flight arrival data from AENA's website. - Utilized Selenium WebDriver with headless Chrome for automation. - Implemented BeautifulSoup for parsing flight details. - Introduced transaction-based execution using `guara.transaction`. - Stored flight data in JSON format while filtering outdated entries. - Handled potential exceptions like `TimeoutException` and `NoSuchElementException`. - Updated script status tracking for better monitoring. * Fix linter issues * Running pre-commit

…ommand executor

theijhay · 2025-02-04T07:47:57Z

Hi @douglasdcm

I’ve been working on the WinAppDriver integration for the Calculator app tests. However, I encountered an issue: WinAppDriver is a Windows-only tool and cannot run on Linux (Ubuntu).

Here’s the situation and potential solutions:

Limitation:

WinAppDriver requires a Windows environment to function.

The tests fail on Linux because the WinAppDriver server cannot be started.

Proposed Solutions:

Option 1: Run the tests on a Windows machine or CI/CD pipeline (e.g., GitHub Actions with a Windows runner).

Option 2: Use a cross-platform alternative like Appium for desktop apps (if applicable).

Option 3: Skip WinAppDriver tests on non-Windows platforms by adding conditional logic.

Let me know which approach you prefer.

If we proceed with Option 3, I can update the PR to skip WinAppDriver tests on Linux.

Looking forward to your feedback!

douglasdcm · 2025-02-07T11:30:08Z

Hi @douglasdcm

I’ve been working on the WinAppDriver integration for the Calculator app tests. However, I encountered an issue: WinAppDriver is a Windows-only tool and cannot run on Linux (Ubuntu).

Here’s the situation and potential solutions:

Limitation:

WinAppDriver requires a Windows environment to function.

The tests fail on Linux because the WinAppDriver server cannot be started.

Proposed Solutions:

Option 1: Run the tests on a Windows machine or CI/CD pipeline (e.g., GitHub Actions with a Windows runner).

Option 2: Use a cross-platform alternative like Appium for desktop apps (if applicable).

Option 3: Skip WinAppDriver tests on non-Windows platforms by adding conditional logic.

Let me know which approach you prefer.

If we proceed with Option 3, I can update the PR to skip WinAppDriver tests on Linux.

Looking forward to your feedback!

Thanks @theijhay we can proceed the same way we did for tests that run on Linux calculator. They are skip. We just need to guarantee it runs locally with Python 3.11. after that we can skip the test.. Maybe use lazy imports too if the win app driver is required while running the tests

…tform check for Windows

douglasdcm

Thanks for the PR. I gave some comments. Add a README file explaining the purpose of the example and the tools involved. Check other examples, please

douglasdcm · 2025-02-08T13:45:28Z

examples/crawler/main.py

@@ -233,14 +232,21 @@ def get_aena_data():
    script_status = read_json_file("script_status.json", {"airports": {}, "status": None})

    # Open the AENA page
+    app.at(OpenAenaPage)


It is not correct. Consider the changes from the original file. In this crawler I use the new method 'when' to improve readability

I did not touch this code sir

I know. I changed at by when. I may be changed back while fixing conflicts . Compara the code against the main branch, please

douglasdcm · 2025-02-08T13:48:08Z

examples/windows_desktop/winappdriver/calculator.py

+            logging.error(f"Error extracting result: {e}")
+            raise
+
+    def validate_result(self, expected: int):


This method can be removed

douglasdcm · 2025-02-08T13:51:56Z

examples/windows_desktop/winappdriver/test_calculator.py

+        from examples.windows_desktop.winappdriver import calculator
+
+        self.app.at(calculator.SumNumbers, num1=5, num2=3).asserts(
+            calculator.SumNumbers().validate_result, 8


Not correct. Use the syntax app.at in high-level design.

examples/windows_desktop/winappdriver/test_calculator.py

…code Refactor get_aena_data() function in main.py Update black language version to python3.11 in .pre-commit-config.yaml Remove complex setup in CI environment for Windows Calculator tests Update test_calculator.py to use it.IAssertion for checking if value is shown in the calculator Update test_calculator.py to use lazy import to avoid breaking the pipeline Update test_calculator.py to use parametrize decorator for addition test cases

theijhay · 2025-02-09T10:43:11Z

Thanks for the PR. I gave some comments. Add a README file explaining the purpose of the example and the tools involved. Check other examples, please

Added

douglasdcm · 2025-02-09T23:29:37Z

examples/crawler/main.py

@@ -233,14 +232,21 @@ def get_aena_data():
    script_status = read_json_file("script_status.json", {"airports": {}, "status": None})

    # Open the AENA page
+    app.at(OpenAenaPage)


I know. I changed at by when. I may be changed back while fixing conflicts . Compara the code against the main branch, please

examples/windows_desktop/winappdriver/test_calculator.py

douglasdcm

Thanks, but there are some comments not fixed yet

douglasdcm · 2025-02-11T12:17:00Z

examples/windows_desktop/winappdriver/setup.py

+        self._driver = webdriver.Remote(
+            command_executor="http://localhost:4723/wd/hub", options=options
+        )
+        self._application = Application(self._driver)


Not correct. The application is the involker of the automation. It call the transactions not the opposite. Check other examples, please

Refactor setup.py: Remove unused import in winappdriver Refactor test_calculator.py: Remove unused import and skip complex setup

douglasdcm

The example is OK. It is just necessary to revert the changes in the crawler file. It may be caused by conflicts solving

examples/crawler/main.py

theijhay added 5 commits January 31, 2025 08:29

Add Windows Calculator example using Guará + WinAppDriver

bdcf93c

Refactor CalculatorTransactions to add logging and error handling

5c3f27a

Refactor CalculatorTransactions to add logging and error handling

f4a2b9c

Refactor CalculatorTransactions to improve code readability and maint…

2fcdf4b

…ainability

Refactor setup.py to remove unnecessary whitespace

eea614d

theijhay requested a review from douglasdcm February 1, 2025 23:50

theijhay added 3 commits February 2, 2025 01:00

Refactor setup.py to remove unnecessary whitespace and improve code r…

34d9a39

…eadability Refactor CalculatorTransactions to add logging and error handling Update test_calculator.py to pass driver object to OpenAppTransaction and CloseAppTransaction

Refactor setup.py to remove unnecessary whitespace and improve code r…

d1e8312

…eadability

Refactor setup.py to remove unnecessary whitespace in CloseAppTransac…

7eb7fc2

…tion class

douglasdcm requested changes Feb 2, 2025

View reviewed changes

theijhay and others added 2 commits February 2, 2025 09:22

Refactor code to improve readability and maintainability

c9613fd

Add precommit (douglasdcm#98)

531e2d7

* Add pre-commit configuration * test * Add black workflow * Formatting the entire code * Set line length

theijhay requested a review from douglasdcm February 2, 2025 09:18

theijhay and others added 4 commits February 2, 2025 10:51

Refactor test_calculator.py to remove unnecessary import

67e6a8f

Merge branch 'main' into feat/winappdriver-integration

c019e0c

Refactor test_calculator.py to remove unnecessary import

8f2fc8c

Refactor test_calculator.py to use SumNumbers instead of CalculatorTr…

8399981

…ansactions

douglasdcm requested changes Feb 2, 2025

View reviewed changes

douglasdcm assigned theijhay Feb 3, 2025

douglasdcm and others added 3 commits February 3, 2025 23:56

Refactor setup.py to use WindowsOptions for driver capabilities

086e348

Refactor setup.py to use localhost instead of IP address for driver c…

30870c6

…ommand executor

theijhay and others added 6 commits February 8, 2025 04:56

Refactor test_calculator.py to remove unnecessary imports and add pla…

cbc35f6

…tform check for Windows

Update black language version to python3.11 in .pre-commit-config.yaml

f239551

Merge branch 'main' into feat/winappdriver-integration

59f97be

Update black language version to python3.11 in .pre-commit-config.yaml

dde07dc

Refactor get_aena_data() function in main.py

ea024a5

Refactor validate_result() method in calculator.py

f1be955

theijhay requested a review from douglasdcm February 8, 2025 04:21

douglasdcm requested changes Feb 8, 2025

View reviewed changes

theijhay added 2 commits February 8, 2025 22:06

Refactor calculator.py: Remove unused import

de9c840

theijhay requested a review from douglasdcm February 8, 2025 21:16

add readme file

b8c4052

douglasdcm reviewed Feb 9, 2025

View reviewed changes

douglasdcm requested changes Feb 11, 2025

View reviewed changes

Refactor main.py: Remove unused code in get_aena_data() function

cc73e94

Refactor setup.py: Remove unused import in winappdriver Refactor test_calculator.py: Remove unused import and skip complex setup

theijhay requested a review from douglasdcm February 11, 2025 22:10

douglasdcm requested changes Feb 12, 2025

View reviewed changes

examples/crawler/main.py Outdated Show resolved Hide resolved

Refactor main.py: Remove unused code in get_aena_data() function

b0d80ce

douglasdcm approved these changes Feb 12, 2025

View reviewed changes

douglasdcm merged commit b8b19be into douglasdcm:main Feb 12, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Windows Calculator Integration and Tests #97

feat: Add Windows Calculator Integration and Tests #97

theijhay commented Feb 1, 2025

douglasdcm left a comment

douglasdcm left a comment •

edited

Loading

theijhay commented Feb 4, 2025

douglasdcm commented Feb 7, 2025

Limitation:

Proposed Solutions:

douglasdcm left a comment

douglasdcm Feb 8, 2025

theijhay Feb 8, 2025

douglasdcm Feb 9, 2025

douglasdcm Feb 8, 2025

douglasdcm Feb 8, 2025

theijhay commented Feb 9, 2025

douglasdcm Feb 9, 2025

douglasdcm left a comment

douglasdcm Feb 11, 2025

douglasdcm left a comment

feat: Add Windows Calculator Integration and Tests #97

feat: Add Windows Calculator Integration and Tests #97

Conversation

theijhay commented Feb 1, 2025

douglasdcm left a comment

Choose a reason for hiding this comment

douglasdcm left a comment • edited Loading

Choose a reason for hiding this comment

theijhay commented Feb 4, 2025

Limitation:

Proposed Solutions:

douglasdcm commented Feb 7, 2025

Limitation:

Proposed Solutions:

douglasdcm left a comment

Choose a reason for hiding this comment

douglasdcm Feb 8, 2025

Choose a reason for hiding this comment

theijhay Feb 8, 2025

Choose a reason for hiding this comment

douglasdcm Feb 9, 2025

Choose a reason for hiding this comment

douglasdcm Feb 8, 2025

Choose a reason for hiding this comment

douglasdcm Feb 8, 2025

Choose a reason for hiding this comment

theijhay commented Feb 9, 2025

douglasdcm Feb 9, 2025

Choose a reason for hiding this comment

douglasdcm left a comment

Choose a reason for hiding this comment

douglasdcm Feb 11, 2025

Choose a reason for hiding this comment

douglasdcm left a comment

Choose a reason for hiding this comment

douglasdcm left a comment •

edited

Loading