Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cleanup #131

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Test Cleanup #131

merged 1 commit into from
Aug 16, 2019

Conversation

doug-martin
Copy link
Owner

  • Test clean up and more testing pattern consistency
    • Changed to use assertion methods off of suite
    • Updated Equals assertions to have expected output first
  • Increase overall test coverage.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #131 into master will increase coverage by 2.48%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   87.45%   89.94%   +2.48%     
==========================================
  Files          47       47              
  Lines        3556     3561       +5     
==========================================
+ Hits         3110     3203      +93     
+ Misses        386      324      -62     
+ Partials       60       34      -26
Impacted Files Coverage Δ
exp/exp_map.go 73.95% <100%> (ø) ⬆️
exp/bool.go 92.1% <92.3%> (+0.21%) ⬆️
sql_dialect.go 96.12% <94.87%> (+10.06%) ⬆️
exp/exp.go 66.66% <97.43%> (+44.44%) ⬆️
sql_dialect_options.go 81.25% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237124...edc1acd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #131 into master will increase coverage by 2.48%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   87.45%   89.94%   +2.48%     
==========================================
  Files          47       47              
  Lines        3556     3561       +5     
==========================================
+ Hits         3110     3203      +93     
+ Misses        386      324      -62     
+ Partials       60       34      -26
Impacted Files Coverage Δ
exp/exp_map.go 73.95% <100%> (ø) ⬆️
exp/bool.go 92.1% <92.3%> (+0.21%) ⬆️
sql_dialect.go 96.12% <94.87%> (+10.06%) ⬆️
exp/exp.go 66.66% <97.43%> (+44.44%) ⬆️
sql_dialect_options.go 81.25% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237124...edc1acd. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #131 into master will increase coverage by 2.48%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   87.45%   89.94%   +2.48%     
==========================================
  Files          47       47              
  Lines        3556     3561       +5     
==========================================
+ Hits         3110     3203      +93     
+ Misses        386      324      -62     
+ Partials       60       34      -26
Impacted Files Coverage Δ
exp/exp_map.go 73.95% <100%> (ø) ⬆️
exp/bool.go 92.1% <92.3%> (+0.21%) ⬆️
sql_dialect.go 96.12% <94.87%> (+10.06%) ⬆️
exp/exp.go 66.66% <97.43%> (+44.44%) ⬆️
sql_dialect_options.go 81.25% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4b383...a7bab45. Read the comment docs.

@doug-martin
Test Cleanup
a7bab45 
* Test clean up and more testing pattern consistency
    * Changed to use assertion methods off of suite
    * Updated Equals assertions to have expected output first
* Increase overall test coverage.

# Conflicts:
#	delete_dataset_test.go
#	insert_dataset_test.go
#	select_dataset_test.go
#	truncate_dataset_test.go
#	update_dataset_test.go
@doug-martin doug-martin merged commit 4acec82 into master Aug 16, 2019
@doug-martin doug-martin deleted the test-cleanup branch October 16, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doug-martin