Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for #119 #124

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Enhancement for #119 #124

merged 1 commit into from
Aug 4, 2019

Conversation

doug-martin
Copy link
Owner

* [Added] Support for `DISTINCT ON` clauses #119
@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #124 into master will decrease coverage by 0.06%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   87.52%   87.45%   -0.07%     
==========================================
  Files          47       47              
  Lines        3550     3556       +6     
==========================================
+ Hits         3107     3110       +3     
- Misses        383      386       +3     
  Partials       60       60
Impacted Files Coverage Δ
sql_dialect_options.go 78.36% <100%> (+0.1%) ⬆️
dialect/mysql/mysql.go 100% <100%> (ø) ⬆️
exp/select_clauses.go 97.6% <100%> (-0.1%) ⬇️
dialect/sqlite3/sqlite3.go 100% <100%> (ø) ⬆️
select_dataset.go 91.93% <100%> (+0.06%) ⬆️
sql_dialect.go 86.06% <73.68%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2137511...6ebed64. Read the comment docs.

@doug-martin doug-martin merged commit 3237124 into master Aug 4, 2019
@doug-martin doug-martin deleted the issue119-enhancement branch October 16, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant