Apply suggestions from code review

Co-authored-by: Chris Duf <chris@openmarl.org>

doc/site/src/getting-started.rst

@@ -282,10 +282,12 @@ Where:
 Batch Mode
 ==========
 
-DTSh can also be used non-interactively, by passing a series of commands to
-execute at startup or a file containing such commands. This is useful for
-scripting and automation. In addition, the ``-i --interactive`` option permits
-to enter the interactive loop after the batch commands have been executed.
+For scripting and automation, DTSh can also be used non-interactively by passing:
+
+ - a series of commands to execute at startup: ``-c CMD1 -c CMD2`` 
+ - or a file containing such commands: ``-f FILE``
+
+The ``-i --interactive`` option then permits to enter the interactive loop after the batch commands have been executed.
 
 For example, to list the contents of the root of the devicetree and then change
 to another directory, before entering the interactive loop, you can use the
@@ -294,7 +296,7 @@ following command:
 .. code-block:: none
 
    $ dtsh -c "ls -l" -c "cd &i2c0" -i
-   dtsh (0.2.0): A Devicetree Shell
+   dtsh (0.2.1): A Devicetree Shell
    How to exit: q, or quit, or exit, or press Ctrl-D
 
    > Name              Labels          Binding

src/dtsh/cli.py

@@ -124,18 +124,17 @@ def batch_source(self) -> Optional[Union[str, List[str]]]:
         """Batch command source, if defined."""
         if self._argv.c:
             return cast(List[str], self._argv.c)
-        elif self._argv.f:
-            return self._argv.f
-        else:
-            return None
+        if self._argv.f:
+            return cast(str, self._argv.f)
+        return None
 
     @property
     def interactive(self) -> bool:
         """Is the interactive loop requested?"""
-        if not self._argv.c and not self._argv.f:
+        if not (self._argv.c or self._argv.f):
             # no batch input, must be interactive
             return True
-        return self._argv.interactive
+        return cast(bool, self._argv.interactive)
 
 
 def _load_preference_file(path: str) -> None:

src/dtsh/io.py

@@ -331,6 +331,6 @@ def readline(self, multi_prompt: Optional[Sequence[Any]] = None) -> str:
         """Overrides DTShInput.readline()."""
         if self._cmds:
             line: str = self._cmds.pop(0)
-            return line.rstrip()
+            return line
 
         raise EOFError()

src/dtsh/rich/session.py

@@ -83,7 +83,7 @@ def create_batch(
             # Batch commands from cli arguments.
             batch_is = DTShInputCmds(batch)
         else:
-            raise NotImplementedError("create_batch({})".format(repr(type(batch))))
+            raise NotImplementedError(f"create_batch({repr(type(batch))})")
 
         dt = cls._create_dtmodel(dts_path, binding_dirs)
         vt = DTShBatchRichVT(batch_is, interactive)