Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: BindingListCollectionView item replace issue (#1314) #2924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix: BindingListCollectionView item replace issue (#1314) #2924

wants to merge 2 commits into from
+12 −0

Conversation

koszeggy
Copy link

Fixes #1314 (BindingListCollectionView ignores item replace). See the issue thread for details along with reproduction and test app.

@koszeggy koszeggy requested a review from a team as a code owner April 23, 2020 15:28
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 23, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent April 23, 2020 15:28
@ryalanms
Copy link
Member

/cc @SamBent

Base automatically changed from master to main March 17, 2021 17:38
@koszeggy
Copy link
Author

@ryalanms, @fabiant3, @SamBent
Is there any chance that this fix goes to .NET 7? I reported the issue 3 years ago and created this fix 2 years ago. Fortunately there is still no conflict but some reviews are still missing.

My issues created for other MS repos (eg. WinForms) are usually processed much faster. Please let me know if I can help in any way.

@lindexi
Copy link
Member

lindexi commented Jun 13, 2022

cc @pchaurasia14

@dipeshmsft dipeshmsft self-assigned this Jun 21, 2022
@ghost ghost assigned koszeggy Jun 21, 2022
@dipeshmsft
Copy link
Member

@koszeggy, I am reviewing the PR currently, the changes look good. Wanted to know if you were able to test your fix with the sample application or not?

@koszeggy
Copy link
Author

@dipeshmsft: Yes, when I created the PR I tested it with a preview version of .NET 5.

@dipeshmsft
Copy link
Member

@koszeggy, can you make the necessary changes for this PR before we take it for a test pass?

@koszeggy
Copy link
Author

koszeggy commented Aug 24, 2023 •
edited
Loading

@koszeggy, can you make the necessary changes for this PR before we take it for a test pass?

Ah ok, it wasn't quite clear to whom "we" was referring to in "we can add that check". :) I need to make my fork up-to-date and allocate some time for it if you wish me to do it. Maybe I can do it this week. But feel free to add these checks if it's quicker and you are already into it.

@koszeggy
Copy link
Author

Please find my reply here.

@koszeggy
Copy link
Author

koszeggy commented Oct 9, 2023

Anyone? 🥺

@dipeshmsft dipeshmsft requested review from pchaurasia14 and removed request for SamBent, ryalanms and fabiant3 October 10, 2023 07:15
@koszeggy koszeggy mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipeshmsft dipeshmsft dipeshmsft left review comments

@pchaurasia14 pchaurasia14 Awaiting requested review from pchaurasia14

At least 1 approving review is required to merge this pull request.

Assignees

@koszeggy koszeggy

@dipeshmsft dipeshmsft

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WPF] BindingListCollectionView ignores item replace
4 participants
@koszeggy @ryalanms @lindexi @dipeshmsft