Fix Application.EnableVisualStyles in single file publishing mode (servicing) #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnet#4149) * Fix Application.EnableVisualStyles in single file publishing mode Application.EnableVisualStyles gives Windows a manifest that enables the v6 common controls. We normally pull this manifest from a native resource in System.Windows.Forms.dll. In single file mode there is no "dll" to load from so this feature was not working as intended. In the case where we can't get a Win32 HMODULE we now fall back to pulling the manifest from a managed resource and dumping it to the temp folder. Make ACTCTXW blittable. (cherry picked from commit 082cbf2)
Codecov Report
@@ Coverage Diff @@
## release/5.0 #4177 +/- ##
======================================================
+ Coverage 68.03138% 98.07412% +30.04273%
======================================================
Files 1416 492 -924
Lines 509681 258687 -250994
Branches 41474 4476 -36998
======================================================
- Hits 346743 253705 -93038
+ Misses 156710 4225 -152485
+ Partials 6228 757 -5471
Flags with carried forward coverage won't be shown. Click here to find out more. |
dreddy-work
approved these changes
Nov 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4145
(cherry picked from commit 082cbf2)
Customer Impact
Application.EnableVisualStylesgives Windows a manifest that enables the v6 common controls. We normally pull this manifest from a native resource in System.Windows.Forms.dll. In single file mode there is no "dll" to load from so this feature was not working as intended.In the case where we can't get a Win32 HMODULE we now fall back to pulling the manifest from a managed resource and dumping it to the temp folder.
ACTCTXWblittable.Regression?
Risk
Microsoft Reviewers: Open in CodeFlow