-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullability error CS8620 in tests #12475
Conversation
cc @ViktorHofer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
Basically it expects either both operands of Contains be |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12475 +/- ##
===================================================
+ Coverage 75.71428% 75.73518% +0.02089%
===================================================
Files 3152 3153 +1
Lines 635711 635797 +86
Branches 46970 46973 +3
===================================================
+ Hits 481324 481522 +198
+ Misses 150944 150841 -103
+ Partials 3443 3434 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fix warning (as error):
This is to unblock dotnet/sdk#44843. I have tested with
10.0.100-alpha.1.24562.4
in global.json, this is the only instance of the error.Microsoft Reviewers: Open in CodeFlow