Omnisharp Razor DLL fix #2178
Merged
Omnisharp Razor DLL fix #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ericstj
reviewed
May 24, 2021
d425bb3 to
06dc859
Compare
06dc859 to
ac426a8
Compare
…ode. This also requires building some runtime and MSBuild packages as net46. Unfortunately we can't rely on the targeting packs for these because source-build does produce the packages but without the net46 runtime currently.
ac426a8 to
7e7abb0
Compare
|
cc @michaelbarkdoll and @tvildo if you'd like to try out this fix. |
dseefeld
approved these changes
Jun 11, 2021
MichaelSimons
approved these changes
Jun 14, 2021
This was referenced Jun 14, 2021
|
Yes, logged #2232 to track that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2006.
Build and ship a net46 version of MS.NET.SDK.Razor to support Omnisharp (and therefore VSCode Intellisense). Some complications:
[fail]: OmniSharp.MSBuild.ProjectLoader The "Microsoft.AspNetCore.Razor.Tasks.DiscoverDefaultScopedCssItems" task could not be loaded from the assembly sdk/5.0.203/Sdks/Microsoft.NET.Sdk.Razor/build/netstandard2.0/../../tasks/net46/Microsoft.NET.Sdk.Razor.Tasks.dll. Invalid Image Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.BuildAllConfigurationsstill has errors in source-build. (XXX log issue XXX):/home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.Configuration.ConfigurationManager/ref/System.Configuration.ConfigurationManager.cs(1383,140): error CS0433: The type 'PermissionSet' exists in both 'System.Security.Permissions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' [/home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.Configuration.ConfigurationManager/ref/System.Configuration.ConfigurationManager.csproj] /home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.Configuration.ConfigurationManager/ref/System.Configuration.ConfigurationManager.cs(1471,125): error CS0433: The type 'PermissionSet' exists in both 'System.Security.Permissions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' [/home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.Configuration.ConfigurationManager/ref/System.Configuration.ConfigurationManager.csproj] /home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.ServiceProcess.ServiceController/ref/System.ServiceProcess.ServiceController.cs(39,43): error CS0433: The type 'EventLog' exists in both 'System.Diagnostics.EventLog, Version=5.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' and 'System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' [/home/chris/dotnet_source-build/artifacts/src/runtime.478b2f8c0e480665f6c52c95cd57830784dc9560/src/libraries/System.ServiceProcess.ServiceController/ref/System.ServiceProcess.ServiceController.csproj]