Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the download scripts to consume cli rel/1.0.0 branch #721

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jan 24, 2017

This fixes the download script to download from the correct location. This is an infrastructure-only change.

@333fred
Copy link
Member Author

333fred commented Jan 24, 2017

Tagging @srivatsn @dotnet/project-system for review.

@333fred
Copy link
Member Author

333fred commented Jan 24, 2017

Until this is merged, new clones will not be able to build, and Jenkins builds will fail.

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unnecessary whitespace changes, it would be nice to only change the script url.

@nguerrera
Copy link
Contributor

💯

@nguerrera
Copy link
Contributor

@333fred removing the whitespace changes in separate commit is the worst of both worlds. No cleanup and still difficult to review diff in history.

@333fred
Copy link
Member Author

333fred commented Jan 24, 2017

@nguerrera squashed

@nguerrera
Copy link
Contributor

:shipit: (thanks for squashing)

@333fred 333fred merged commit 6cee74c into master Jan 24, 2017
@333fred 333fred deleted the fix-download branch January 24, 2017 23:48
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
…0190620.1 (dotnet#721)

- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview7.19320.1
- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview7.19320.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants