Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/razor #46633

Merged
merged 10 commits into from
Feb 11, 2025
Merged

[main] Update dependencies from dotnet/razor #46633

merged 10 commits into from
Feb 11, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 7, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
  • Build: 20250210.3
  • Date Produced: February 11, 2025 8:25:58 AM UTC
  • Commit: ddad4c8d949980d5b289f716439a34a3a0a28b83
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
242604e 
…06.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25106.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Feb 7, 2025
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
e5b460b 
…06.2

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25106.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
82469df 
…07.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25107.1
@build-analysis build-analysis bot mentioned this pull request Feb 7, 2025
Open
dotnet-maestro bot and others added 3 commits February 7, 2025 18:29
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
9097a9c 
…07.2

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25107.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
1278dd3 
…07.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25107.3
@lewing
Merge branch 'main' into darc-main-245076b3-f4d8-40b1-9f98-e7f662a83c42
a315912
@v-wuzhai
Copy link
Member

v-wuzhai commented Feb 8, 2025

@ViktorHofer PTAL

@ViktorHofer
Copy link
Member

@dotnet/source-build

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
6e47498 
…09.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25109.1
This was referenced Feb 10, 2025
Open
Open
Open
@MichaelSimons
Copy link
Member

@dotnet/source-build

The source-build leg is passing. It looks like the @dotnet/razor-tooling team needs to address some failures surfaced when building with a recent SDK.

    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\AutoInsert\IOnAutoInsertProvider.cs(12,17): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\AutoInsert\IOnAutoInsertProvider.cs(12,17): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)
    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Completion\Delegation\IDelegatedCSharpCompletionResponseRewriter.cs(13,43): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Completion\Delegation\IDelegatedCSharpCompletionResponseRewriter.cs(13,43): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)
    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\IFileSystem.cs(11,32): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\IFileSystem.cs(11,32): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)
    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\IFileSystem.cs(13,32): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\IFileSystem.cs(13,32): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)
    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Protocol\IDelegatedParams.cs(11,45): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Protocol\IDelegatedParams.cs(11,45): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)
    D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Protocol\IDelegatedParams.cs(12,30): error IDE0040: Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040) [D:\a\_work\1\vmr\src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Microsoft.CodeAnalysis.Razor.Workspaces.csproj::TargetFramework=netstandard2.0]
##[error]src\razor\src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\Protocol\IDelegatedParams.cs(12,30): error IDE0040: (NETCORE_ENGINEERING_TELEMETRY=Build) Accessibility modifiers required (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0040)

@ViktorHofer
Copy link
Member

Sorry for the wrong ping.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
5a44085 
…10.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25110.1
@davidwengier
Copy link
Member

This would have been broken by dotnet/razor#11466, though I'm not sure why we're not getting warnings in our repo for these.

@davidwengier
Copy link
Member

Oh interesting, these are all interfaces. The default for IDE0040 is to only report for non-interface members. Maybe something else is being brought in to the build that is elevating that to always report?

I'll fix the violations in Razor, but I'd love to get to the bottom of this so we don't inadvertently hit it again in future. I guess I can try running the VMR build locally? If anyone has any other tips I'd love to hear them!

@davidwengier davidwengier mentioned this pull request Feb 10, 2025
Merged
@davidwengier
Copy link
Member

Fix in dotnet/razor#11472

davidwengier added a commit to dotnet/razor that referenced this pull request Feb 10, 2025
@davidwengier
Remove accessibility modifiers from interface members (#11472)
5b92168 
Fixes build errors in dotnet/sdk#46633
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
af2f1b1 
…10.2

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25110.2
@davidwengier davidwengier mentioned this pull request Feb 11, 2025
Merged
@davidwengier
Copy link
Member

2nd fix in dotnet/razor#11474

davidwengier added a commit to dotnet/razor that referenced this pull request Feb 11, 2025
@davidwengier
Fix another IDE0040 violation (#11474)
ddad4c8 
Fixes another failure in dotnet/sdk#46633
@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202502…
c780ff9 
…10.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.25105.3 -> To Version 9.0.0-preview.25110.3
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 11, 2025 12:22
@ViktorHofer ViktorHofer merged commit 0065640 into main Feb 11, 2025
40 of 43 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-245076b3-f4d8-40b1-9f98-e7f662a83c42 branch February 11, 2025 12:22
This was referenced Feb 11, 2025
Open
Open
@davidwengier davidwengier mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-wuzhai @ViktorHofer @MichaelSimons @davidwengier @lewing