Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Testhost packable except in source-only #46480

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Feb 3, 2025

No description provided.

@mmitche
Copy link
Member Author

mmitche commented Feb 3, 2025

May have issues with this, verifying.

@@ -5,7 +5,7 @@

<PropertyGroup>
<!-- Don't produce this package when building from source or inside the VMR as it doesn't build correctly on non-Windows. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this comment when sending the PR to VSTest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I will if the test here succeeds.

@mmitche
Copy link
Member Author

mmitche commented Feb 3, 2025

@NikolaMilosavljevic

@mmitche mmitche closed this Feb 3, 2025
@mmitche mmitche reopened this Feb 3, 2025
@NikolaMilosavljevic
Copy link
Member

VMR and source-only builds are green. Failures are unrelated to this change. Can this be merged?

@NikolaMilosavljevic
Copy link
Member

@mmitche can this be merged now?

@mmitche mmitche enabled auto-merge (squash) February 4, 2025 22:30
@mmitche mmitche disabled auto-merge February 4, 2025 22:30
@mmitche mmitche merged commit e897caa into dotnet:main Feb 4, 2025
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants