Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual home variable lookup #46349

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

kasperk81
Copy link
Contributor

@kasperk81 kasperk81 requested a review from a team as a code owner January 28, 2025 02:11
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 28, 2025
@ViktorHofer
Copy link
Member

@dotnet/dotnet-cli PTAL

@kasperk81
Copy link
Contributor Author

@baronfel and @marcpopMSFT i have waiting for months on this #44266 and really hope it makes it into .NET 10 preview. the current desync state is more problematic, so it feels like the options are either to take this change or revert the other two related ones in runtime and nuget. also, the scope of this change is limited to cases where the HOME variable isn’t set, so it avoids most usual use cases.

@ViktorHofer
Copy link
Member

@kasperk81 we already snapped for .NET 10 Preview 1. Does this need to go into the first preview? If so, we would need to ask for approval.

@baronfel
Copy link
Member

I don't think this is pressing enough to break glass for p1. It's important we get it into 10 previews period though.

@kasperk81
Copy link
Contributor Author

it's targeting main branch so p1 is not affected.

@ViktorHofer ViktorHofer merged commit 7d3013e into dotnet:main Jan 29, 2025
35 of 38 checks passed
@kasperk81 kasperk81 deleted the homeenvivar branch January 29, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants