-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dotnet/runtime #35048
[main] Update dotnet/runtime #35048
Changes from 30 commits
5a7e1f2
ac96fe8
09e6547
8bed3cf
98927b2
ab87475
ef8f565
f8f8fc2
4e46d4a
c6361e1
e4063cf
3cc46c9
4593590
54e2592
bb4134f
01a01e5
38e3276
71cc422
90ee7e0
3cd48fd
0bdd9e7
42f534a
f8ef959
a1ee049
4ecccd1
882db45
ef678de
ab71881
ce306be
d1f1784
ca8ddf9
26162bd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,46 +14,46 @@ | |
<Sha>9dfddc30a1e9101f7e44dcda57d95902073e444c</Sha> | ||
<SourceBuild RepoName="templating" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NETCore.App.Ref" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NETCore.App.Ref" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.8.0" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.9.0" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
<SourceBuild RepoName="runtime" ManagedOnly="false" /> | ||
</Dependency> | ||
<Dependency Name="VS.Redist.Common.NetCore.TargetingPack.x64.8.0" Version="8.0.0-rc.1.23421.3"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NETCore.App.Host.win-x64" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NETCore.App.Host.win-x64" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NETCore.Platforms" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NETCore.Platforms" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NET.HostModel" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NET.HostModel" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.Extensions.DependencyModel" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.Extensions.DependencyModel" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NETCore.DotNetHostResolver" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NETCore.DotNetHostResolver" Version="9.0.0-alpha.1.23455.1"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this intentionally incoherent with the other runtime dependencies? They are on version 9.0.0-alpha.1.23464.19 and sha a6c64c3c26417f579022e20cbcee992b4814ed2c. This is the source of the following source-build prebuilts that are being reported:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We actually removed |
||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>90042669ef7e2d829aa605cb3751760b6161d12a</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport" Version="8.0.0-rc.1.23411.2" CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64"> | ||
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport" Version="9.0.0-alpha.1.23457.3" CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64"> | ||
<Uri>https://github.com/dotnet/emsdk</Uri> | ||
<Sha>abfa03c97f4175d4d209435cd0e71f558e36c3fd</Sha> | ||
<Sha>7da45c33d57a762de5756f2c090e84327dae143f</Sha> | ||
<SourceBuild RepoName="emsdk" ManagedOnly="true" /> | ||
</Dependency> | ||
<Dependency Name="Microsoft.Build" Version="17.8.0-preview-23462-02"> | ||
|
@@ -197,25 +197,25 @@ | |
<Uri>https://github.com/microsoft/vstest</Uri> | ||
<Sha>bb99e3ea07aaecd62d5c59568524133317d081b4</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="System.CodeDom" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.CodeDom" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="System.Security.Cryptography.ProtectedData" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.Security.Cryptography.ProtectedData" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="System.Text.Encoding.CodePages" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.Text.Encoding.CodePages" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="System.Resources.Extensions" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.Resources.Extensions" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.WindowsDesktop.App.Runtime.win-x64" Version="9.0.0-alpha.1.23456.3"> | ||
<Uri>https://github.com/dotnet/windowsdesktop</Uri> | ||
|
@@ -390,19 +390,19 @@ | |
<SourceBuild RepoName="symreader" ManagedOnly="true" /> | ||
</Dependency> | ||
<!-- Dependency required for flowing correct package version in source-build, using PVP flow. --> | ||
<Dependency Name="Microsoft.Extensions.Logging.Console" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.Extensions.Logging.Console" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<!-- Dependency required for flowing correct package version in source-build, using PVP flow. --> | ||
<Dependency Name="Microsoft.Extensions.FileSystemGlobbing" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="Microsoft.Extensions.FileSystemGlobbing" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<!-- Dependency required for flowing correct package version in source-build, using PVP flow. --> | ||
<Dependency Name="System.ServiceProcess.ServiceController" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.ServiceProcess.ServiceController" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
</ProductDependencies> | ||
<ToolsetDependencies> | ||
|
@@ -423,9 +423,9 @@ | |
<Uri>https://github.com/dotnet/arcade</Uri> | ||
<Sha>1d451c32dda2314c721adbf8829e1c0cd4e681ff</Sha> | ||
</Dependency> | ||
<Dependency Name="System.Reflection.MetadataLoadContext" Version="8.0.0-rc.1.23421.3"> | ||
<Dependency Name="System.Reflection.MetadataLoadContext" Version="9.0.0-alpha.1.23464.19"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>f8c110b8003d68cc635add4ca791d6cf2e645561</Sha> | ||
<Sha>a6c64c3c26417f579022e20cbcee992b4814ed2c</Sha> | ||
</Dependency> | ||
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23426.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> | ||
<Uri>https://github.com/dotnet/xliff-tasks</Uri> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<Project /> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
<Project> | ||
<!-- Overriding only when workload is installed, and targeting net8.0 --> | ||
<Import Project="WasmOverridePacks.targets" Condition="'$(WasmNativeWorkload)' == 'true' and '$(RuntimeIdentifier)' == 'browser-wasm' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionEquals('$(TargetFrameworkVersion)', '8.0'))" /> | ||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that needed? That switch isn't intended to be set by our own repositories. It's a last effort escape switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build was throwing a massive number of errors about incompatible runtime targeting. In prior years, we have not had to retarget the SDK before merging in a new runtime so this seems to be a new error:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=393849&view=logs&j=fa59fe4e-195c-56fa-189b-58fd241f10dd&t=e0ea3df6-0956-547c-f7b9-9062676d48ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So adding that flag was to suppress the error so we could get runtime merged and then retarget later (last year, retargetting happened ~3 months after rebranding)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/runtime retargeting happen soon after rebranding this year while that happened around December last year. That's probably the reason why you weren't impacted by this.
IMO it makes sense to do the retargeting here as part of consuming the new runtime. IIRC that's what we did in the previous releases, before .NET 7. But if this switch is just here for a few weeks, I'm fine with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, I didn't realize runtime was that late last time around. That explains it. I'd like to take this whatever the shortest path to fixing the failures is