[ASP.NET] Remove versions from baselines #29093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
commented
Nov 16, 2022
Comment on lines
+76
to
+84
| switch (comparisonMode) | ||
| { | ||
| case GroupComparisonMode.Exact: | ||
| break; | ||
| case GroupComparisonMode.AllowAdditionalAssets: | ||
| break; | ||
| default: | ||
| break; | ||
| } |
There was a problem hiding this comment.
TODO: we plan to allow tests to pass even if the baselines do not exactly match in some circumstances (like if there are additional dlls and so on).
For that, we will compare the list of assets by groups of assets instead of as a flat list and apply different validation rules to each group.
9c9ddcb to
676ef5f
Compare
|
There seem to be a set of unrelated tests that are consistently failing.
Going to merge as these changes should not affect those tests. |
* Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest. * Removes all the versions and hashes from all the files Wed generate. * Splits the code for generating and comparing the baselines into their own classes for better maintenance. * Updates the baselines to reflect the new format.
676ef5f to
45d4a57
Compare
javiercn
added a commit
that referenced
this pull request
Nov 18, 2022
* Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest. * Removes all the versions and hashes from all the files Wed generate. * Splits the code for generating and comparing the baselines into their own classes for better maintenance. * Updates the baselines to reflect the new format.
javiercn
added a commit
that referenced
this pull request
Nov 18, 2022
* Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest. * Removes all the versions and hashes from all the files Wed generate. * Splits the code for generating and comparing the baselines into their own classes for better maintenance. * Updates the baselines to reflect the new format.
javiercn
added a commit
that referenced
this pull request
Nov 18, 2022
* Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest. * Removes all the versions and hashes from all the files Wed generate. * Splits the code for generating and comparing the baselines into their own classes for better maintenance. * Updates the baselines to reflect the new format.
|
Thanks for this PR, the watch tests are unrelated and being tracked here: #29099 |
|
@nagilson unfortunately this is blocking me from merging. |
|
@marcpopMSFT can you force-merge this given that the cause for failures is known and is being tracked separately? |
javiercn
added a commit
that referenced
this pull request
Nov 18, 2022
* Updates the way the baselines are compared to generate a template of the baselines from the current manifest and compare it against the existing template instead of applying the current versions to the baseline and comparing it against the generated manifest. * Removes all the versions and hashes from all the files Wed generate. * Splits the code for generating and comparing the baselines into their own classes for better maintenance. * Updates the baselines to reflect the new format.
|
I have used the force |
marcpopMSFT
added a commit
that referenced
this pull request
Nov 18, 2022
…aselines-7200 [ASP.NET] Remove versions from baselines (#29093)
marcpopMSFT
added a commit
that referenced
this pull request
Nov 29, 2022
…aselines-6100 [ASP.NET] Remove versions from baselines (#29093)
marcpopMSFT
added a commit
that referenced
this pull request
Nov 29, 2022
…aselines-7100 [ASP.NET] Remove versions from baselines (#29093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we perform baseline comparisons by removing the artifacts from the generated baselines and comparing the templates against each other instead of applying certain values to the templates