[Internal -> External Port (7.0.1xx-RC2)] Fix SDK Temp Paths #28476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dir and seems fine
…eng/internal/_git/dotnet-sdk into nagilson-INTERNAL-tempfix
…re because we need someone to make a file with secure permissions and gettempfilename does that but getrandomfilename does not. Moving a file would override the permissions so we copy file contents over.
…this new lib, need to ask some people
…eng/internal/_git/dotnet-sdk into nagilson-INTERNAL-tempfix
… nagilson-INTERNAL-tempfix-play
…son-internal-tempfix-vnext
|
@dsplaisted We're not sure if we need this for RC2 yet. |
2 tasks
|
We don't need it for rc2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirming file permissions are using 700:
The first image shows the temp path created by file utilities in the biggest exploit (Nuget Packages under sudo).
The second image shows the permissions on the file to be drwx-----
[Images redacted for internal only]