Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0 -> 7.0.2 Backport] Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ #28376

Closed
wants to merge 10 commits into from

Conversation

nagilson
Copy link
Member

@nagilson nagilson commented Oct 7, 2022

For #26031
See more details on the 8.0 PR: #28412

@build-analysis build-analysis bot mentioned this pull request Oct 7, 2022
2 tasks
@nagilson nagilson self-assigned this Oct 7, 2022
@nagilson nagilson changed the title Add RuntimeSpecific Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ Oct 7, 2022
@nagilson nagilson changed the title Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ [8.0 -> 7.0.2 Backport] Make Apps RID Specific By Default & RID Now FDD By Default in 8.0+ Oct 10, 2022
@@ -61,6 +61,14 @@ Copyright (c) .NET Foundation. All rights reserved.
<RuntimeIdentifier Condition="'$(PlatformTarget)' == 'x86' or '$(PlatformTarget)' == ''">win7-x86</RuntimeIdentifier>
</PropertyGroup>

<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and '$(OutputType)' == 'Exe'">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and '$(OutputType)' == 'Exe'">
<PropertyGroup Condition="'$(RuntimeSpecific)' == '' and '$(_TargetFrameworkVersionWithoutV)' != '' and '$(_TargetFrameworkVersionWithoutV)' >= '8.0' and ('$(OutputType)' == 'Exe' or '$(OutputType)' == 'WinExe')">

@nagilson
Copy link
Member Author

We aren't doing this proposal anymore, there is a new proposal

@nagilson nagilson closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants