Fix Property Parsing in Publish #28059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darwin pipeline failing due to infrastructure issues. Opening PR for review |
am11
reviewed
Sep 21, 2022
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
Make parser static again instead of internal Fix last remaining test Squash me
6284cb7 to
df90a9f
Compare
|
Approved via email |
dsplaisted
approved these changes
Sep 22, 2022
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
baronfel
requested changes
Sep 22, 2022
baronfel
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28022
Backport:
#28061 (please approve this too!)
Post-Moderm:
I intercepted the
MSBuildPropertyParsercode stack too many interface layers in, so for some edge cases, properties passed via/pand-pwere not fully parsed as it wasn't running through theOptionsForwarding code. The ones I had tested did get parsed but for example in the above case they weren't fully parsed. Also removes an erroneous comment from the code that was old and slipped in.Risk:
Medium
Reason To Accept:
Fixes a bug which will cause erroneous errors inside of
dotnet publish. The PublishRelease code will do an MSBuild evaluation with faulty properties which could have any number of side effects, but in general it would be unrelated to what actually gets published. Still, this is high impact and should be merged in.Testing: [OK]
dotnet publish -p:PublishRelease=true -property Configuration=Debugdotnet publish -p:PublishRelease=true -p Configuration=DebugAlso
dotnet publish -f net7.0Also
dotnet publishwithPublishReleaseinside of a.csproj