Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project references to WinRT Components #19218

Closed
wants to merge 1 commit into from
Closed

Support project references to WinRT Components #19218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ Copyright (c) .NET Foundation. All rights reserved.

<Target Name="RemoveManagedWinRTComponentWinMDReferences"
AfterTargets="ResolveProjectReferences">

<ItemGroup>
<!-- Before we remove them from _ResolvedProjectReferencePaths, grab the implementation .dll's path -->
<ManagedWinRTComponentImplementations
Include="@(_ResolvedProjectReferencePaths->'%(ManagedImplementation)')"
Condition="('%(_ResolvedProjectReferencePaths.Extension)' == '.winmd') And ('%(_ResolvedProjectReferencePaths.Implementation)' == 'WinRT.Host.dll')"
/>
</ItemGroup>

<!-- Managed WinRT components include both the WinMD and the .NET DLL in the result from GetTargetPath. Managed projects need to only reference the .NET DLL, not the WinMD.
The WinMD in this case can be identified because the Implementation metadata value is WinRT.Host.dll. So here we remove any such WinMD references. -->
Expand All @@ -68,4 +76,12 @@ Copyright (c) .NET Foundation. All rights reserved.
</ItemGroup>

</Target>

<Target Name="AddWinRTComponentImplementationReference" AfterTargets="ResolveProjectReferences" DependsOnTargets="RemoveManagedWinRTComponentWinMDReferences" Condition="'@(ManagedWinRTComponentImplementations)' != ''">

<ItemGroup>
<Reference Include="@(ManagedWinRTComponentImplementations)"/>
</ItemGroup>

</Target>
</Project>