Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PerfTrace Support #15241

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Conversation

brianrob
Copy link
Member

@brianrob brianrob commented Jan 8, 2021

Fixes #14392.

This shows up in some of the CLI performance analysis that I've done. The cost is pretty low, but we don't need it anymore either.

@brianrob brianrob requested a review from wli3 January 8, 2021 21:56
@brianrob
Copy link
Member Author

brianrob commented Jan 8, 2021

cc: @marcpopMSFT

Copy link

@wli3 wli3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for help removing this!

@brianrob
Copy link
Member Author

brianrob commented Jan 9, 2021

Thanks for the review @wli3!

@brianrob brianrob merged commit 3b0a7d4 into dotnet:master Jan 9, 2021
@brianrob brianrob deleted the remove-perftracing branch January 9, 2021 04:46
@stephentoub
Copy link
Member

Contributes to dotnet/msbuild#5876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PerfTrace.cs and everything related
3 participants