Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled failing unexpectedly in 8.0.1xx and 9.0.1xx #46006

Closed
marcpopMSFT opened this issue Jan 15, 2025 · 16 comments · Fixed by dotnet/runtime#111530
Labels
Area-NativeAOT Native AOT compilation Known Build Error Test Debt untriaged Request triage from a team member

Comments

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Jan 15, 2025

Filing this so I can disable the test and merge on red
https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233&view=results
https://dev.azure.com/dnceng-public/public/_build/results?buildId=917198&view=results

 The command output contained a result it should not have contained: warning

�[m�[37m        HellowWorldNativeAotApp -> /private/tmp/helix/working/B7C709A6/w/9D0408F8/e/testExecutionDirectory/NativeAot_hw_---788461B1_2/HellowWorldNativeAotApp/bin/Debug/net8.0/osx-x64/HellowWorldNativeAotApp.dll
�[m�[37m        Generating native code
�[m�[37m        ld: warning: __LD,__compact_unwind entries for _RhpNewFast overlap at offset 0x32

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "The command output contained a result it should not have contained: warning",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233
Error message validated: [The command output contained a result it should not have contained: warning]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/16/2025 6:10:01 PM UTC

Report

Build Definition Test Pull Request
920682 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46077
920686 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46079
919402 dotnet/sdk Microsoft.NET.Publish.Tests.dll.3.WorkItemExecution #46033
920774 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46038
920705 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46081
920695 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46080
920684 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46078
920795 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46057
920794 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46071
920700 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46067
919534 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46038
920593 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
920599 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
920595 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
920483 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
920470 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46067
920378 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #46067
920077 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
920076 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled
917233 dotnet/sdk Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_hw_runs_with_no_warnings_when_PublishAot_is_enabled #45963

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
19 20 20

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=917233
Error message validated: [The command output contained a result it should not have contained: warning]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 1/16/2025 6:10:01 PM UTC

@marcpopMSFT
Copy link
Member Author

FWIW, we changed the test in main to ignore this warning: 6a07932

@agocke
Copy link
Member

agocke commented Jan 16, 2025

@MichalStrehovsky FYI

If this is Mac-only I wonder if it's an update to the Mac linker that could b e producing a new warning.

cc @filipnavara

@filipnavara
Copy link
Member

There was a previous occurrence of this. I believe it was mixing of artifacts compiled on machines with different Xcode versions. I'll link back the comment with explanation if I find it.

@filipnavara
Copy link
Member

#43015 (comment)

@MichalStrehovsky
Copy link
Member

We still suppress warnings from ld on macOS so this (fortunately?) won't show up as a warning to the end user, just some text in stdout that most people won't even see: https://github.com/dotnet/runtime/blob/db7e9abb70208a67e686fdb6a593618649a2ed7e/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets#L366C10-L370

@filipnavara
Copy link
Member

I checked the compiler output. The entries in the __compact_unwind table are duplicated (with identical information). Presumably one copy is the one generated by NESTED_END macro in src/coreclr/pal/inc/unixasmmacrosamd64.inc and the other one is generated by the compiler itself. This is mostly harmless but I will check if we can avoid producing such object files.

@jkotas
Copy link
Member

jkotas commented Feb 5, 2025

There was an earlier request from Unity people to backport the Xcode build fixes to release/8.0 and I have the changes ready in a branch.

@filipnavara Could you please share a link to the request? What are the PRs that the backport would have to include?

@agocke
Copy link
Member

agocke commented Feb 5, 2025

I’m supportive of the backport as well — we should keep supported tooling compatible with current Apple tooling.

@filipnavara
Copy link
Member

filipnavara commented Feb 5, 2025

The Unity request was communicated on Discord. I believe they integrated the backport in their fork (folded as the last commits of Unity-Technologies/runtime#270).

The PRs that would need to be backported are dotnet/runtime#106800 for .NET 8, and dotnet/runtime#111530 for .NET 8 and .NET 9.

@jkotas
Copy link
Member

jkotas commented Feb 5, 2025

These looks reasonable to backport. @filipnavara Could you please create the backport PRs?

@marcpopMSFT
Copy link
Member Author

Thanks. I'll let my team know and we'll continue to merge on red for these failures in 8 and 9 PRs.

@agocke
Copy link
Member

agocke commented Feb 6, 2025

Fixes have been merged. This should resolve itself in the sdk after runtime integration.

@marcpopMSFT
Copy link
Member Author

Fixes have been merged. This should resolve itself in the sdk after runtime integration.

@agocke merged for both 8 and 9 for the March release? So we should see this once the March changes flow publicly on release day in March?

@agocke
Copy link
Member

agocke commented Feb 10, 2025

Merged to both 8 and 9. I assume this will make the march release, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NativeAOT Native AOT compilation Known Build Error Test Debt untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants