Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SDK should error if a FrameworkReference is not supported for a certain TFM #3011

Closed
nkolev92 opened this issue Mar 7, 2019 · 1 comment
Closed

The SDK should error if a FrameworkReference is not supported for a certain TFM #3011

nkolev92 opened this issue Mar 7, 2019 · 1 comment
Milestone
3.0.1xx

Comments

@nkolev92
Copy link
Contributor

nkolev92 commented Mar 7, 2019 •
edited
Loading

Came up during the design discussion for FrameworkReference + NuGet.
NuGet/Home#7342

The SDK should error if a FrameworkReference is not supported for a certain TFM.

  • In the project author case, clearly call out that this is an authoring mistake.
  • In the transitive (project/package) case, clearly blame the package/project.

It's worth considering how we handle bad framework assemblies.

//cc @nguerrera
@nguerrera nguerrera added this to the 3.0.1xx milestone Mar 14, 2019
@dsplaisted
Copy link
Member

I believe this is done

dsplaisted pushed a commit to dsplaisted/sdk that referenced this issue Feb 19, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/core-setup build 2…
3109d21 
…0190930.27 (dotnet#3011)

- Microsoft.NETCore.App.Runtime.win-x64 - 3.1.0-preview1.19480.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1xx
Development

No branches or pull requests
3 participants
@nguerrera @dsplaisted @nkolev92