Skip to content

Commit

Permalink
Style updates based on PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
dsplaisted committed Apr 20, 2018
1 parent 30e87c6 commit adfc2bb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public void ItBuildsDependencyContextsFromProjectLockFiles(
Constants.DefaultPlatformLibrary,
isSelfContained: !string.IsNullOrEmpty(runtime));

DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext, false)
DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext, includeRuntimeFileVersions: false)
.WithDirectReferences(directReferences)
.WithCompilationOptions(compilationOptions)
.Build();
Expand Down Expand Up @@ -260,7 +260,7 @@ private DependencyContext BuildDependencyContextWithReferenceAssemblies(bool use
useCompilationOptions ? CreateCompilationOptions() :
null;

DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext, false)
DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext, includeRuntimeFileVersions: false)
.WithReferenceAssemblies(ReferenceInfo.CreateReferenceInfos(referencePaths))
.WithCompilationOptions(compilationOptions)
.Build();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
using System;
// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
Expand Down Expand Up @@ -83,13 +86,13 @@ public void Versions_are_included_in_deps_json()
[Fact]
public void Versions_are_not_included_for_self_contained_apps()
{
Versions_are_not_included(false);
Versions_are_not_included(build: false);
}

[Fact]
public void Versions_are_not_included_for_build()
{
Versions_are_not_included(true);
Versions_are_not_included(build: true);
}

private void Versions_are_not_included(bool build, [CallerMemberName] string callingMethod = "")
Expand Down

0 comments on commit adfc2bb

Please sign in to comment.