Implement marshallers for Span and ReadOnlySpan #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
DllImportGenerator/DllImportGenerator.IntegrationTests/SpanTests.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jun 12, 2021
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
* Implement marshallers for Span/ReadOnlySpan. * Add tests for span marshalling. * Remove unused code. * PR feedback. * Use dotnet/runtime style. * Fix allocation size in ReadOnlySpanMarshaller<T>. Commit migrated from dotnet/runtimelab@e9876f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement marshallers for Span and ReadOnlySpan to show the extensibility model for a new interop type.
When we move in-box, we can annotate
Span<T>andReadOnlySpan<T>with[NativeMarshalling]attributes pointing to their default marshallers and remove some of the[MarshalUsing]attributes.