Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc comments #99331

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix doc comments #99331

merged 1 commit into from
Jul 22, 2024

Conversation

bfriesen
Copy link
Contributor

@bfriesen bfriesen commented Mar 5, 2024

Looks like copy/paste errors.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 5, 2024
Copy link

@mrudat mrudat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks accurate to me.

@am11 am11 added area-System.Diagnostics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The change looks good. Note, though, that currently such changes will not automatically propagate to the official docs. A separate PR to update https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System.Diagnostics.CodeAnalysis/MemberNotNullWhenAttribute.xml would be needed.

@stephentoub stephentoub merged commit f1dd158 into dotnet:main Jul 22, 2024
176 of 178 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants