Fix incorrect exception argument in DbConnectionOptions #98826
Conversation
| @@ -190,7 +190,7 @@ internal static void ValidateKeyValuePair(string keyword, string value) | |||
| } | |||
| if ((null != value) && value.Contains('\0')) | |||
| { | |||
| throw ADP.InvalidValue(keyword); | |||
| throw ADP.InvalidValue(value); | |||
There was a problem hiding this comment.
Actually, why does this need to change to value? The argument here is the parameter name, right?
There was a problem hiding this comment.
I am actually considering that it should be nameof(value). It's expecting the parameter name, returning an ArgumentException.
There was a problem hiding this comment.
Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source
https://source.dot.net/#System.Data.Common/System/Data/Common/DbConnectionStringBuilder.cs,98
There was a problem hiding this comment.
Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source
https://source.dot.net/#System.Data.Common/System/Data/Common/DbConnectionStringBuilder.cs,98
Right, I suspect that was the original intent.
No description provided.