Fix isKnonwNonNull for box and unbox #97799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
This was referenced Feb 1, 2024
|
Is a test possible? |
I wasn't able to make one. VNF_Box can probably be even removed as unused and Unbox is typically expanded early on fast and slow path, wasn't able to repro the issue for the slow path, but it could potentially manifest in future? |
jakobbotsch
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VNF_Boxfunction is not marked as "never-null" (unlikely to have an effect)VNF_Unboxwas marked as "never-null" which is not correct as it might return 0.