Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WasmDedup=false to S.N.Tensors.Tests #96701

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

tannergooding
Copy link
Member

This worksaround #96631

@ghost
Copy link

ghost commented Jan 9, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This worksaround #96631

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics

Milestone: -

@tannergooding
Copy link
Member Author

CC. @vargaz

What CI leg needs to be triggered to validate the fix?

There's notably also a similar issue with #96630, but I believe that is impacting System.Private.Corelib and I wouldn't expect we want the same fix there.

@tannergooding tannergooding merged commit 89411b7 into dotnet:main Jan 10, 2024
111 checks passed
@tannergooding tannergooding deleted the fix-96631 branch January 10, 2024 19:49
@vargaz
Copy link
Contributor

vargaz commented Jan 11, 2024

/azp run runtime-wasm

@vargaz
Copy link
Contributor

vargaz commented Jan 11, 2024

Looks like this was not enough:
https://github.com/dotnet/runtime/pull/96108/checks?check_run_id=20367132467
We probably need to disable this test suite on wasm for now.

tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants