[browser][HybridGlobalization] Fix incorrect value in FirstDayOfWeek test
#93595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsThis draft PR checks if the change fixes failures. It is not a fix itself.
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis draft PR checks if the change fixes failures from #93354. It is not a fix itself.
|
This was referenced Oct 17, 2023
pavelsavara
reviewed
Oct 18, 2023
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Browser.cs
Outdated
Show resolved
Hide resolved
pavelsavara
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93354.
0 decodes Sunday, 1 decodes Monday. We did not have exception wrapping when returning the value from JS function, so it was pointing to a random value in memory. If we were unlucky that this value was equal
0then we were assuming the JS code returned exception and returning the default value forDayOfWeekwhich isSunday.