Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix some issues for CoreRoot test cases: #93187

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[LoongArch64] Fix some issues for CoreRoot test cases: #93187

merged 2 commits into from
Oct 11, 2023

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented Oct 8, 2023 •
edited
Loading

This PR is part of the issue #69705 to amend the LA's port.

Fix some issues for CoreRoot test cases:

  • fix the cast of floating-point types to uint32 in volatileLocal1.dll.
  • fix the register conflict for large offset addresses of OSR root frames when DOTNET_JitStressRegs=2 in more_tailcalls.sh.

@LuckyXu-HF
[LoongArch64] Fix some issues for CoreRoot test cases:
2d79d39 
* fix the cast of floating-point types to uint32 in volatileLocal1.dll.
* fix the register conflict for large offset addresses of OSR root frames when `DOTNET_JitStressRegs=2` in more_tailcalls.sh.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 8, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 8, 2023
@ghost
Copy link

ghost commented Oct 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • fix the cast of floating-point types to uint32 in volatileLocal1.dll.
  • fix the register conflict for large offset addresses of OSR root frames when DOTNET_JitStressRegs=2 in more_tailcalls.sh.
Author: LuckyXu-HF
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@LuckyXu-HF
Copy link
Contributor Author

cc @shushanhf
Could you please review this PR? Thanks.

jakobbotsch
jakobbotsch approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the feedback.

@jakobbotsch jakobbotsch merged commit e0da4d5 into dotnet:main Oct 11, 2023
@LuckyXu-HF LuckyXu-HF deleted the main-LA64A branch October 11, 2023 08:54
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shushanhf shushanhf shushanhf left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckyXu-HF @jakobbotsch @shushanhf