Implement Linq AggregateBy method for IEnumerable and IQueryable #92089
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-linq Issue DetailsCloses #91533
|
| TAccumulate seed, | ||
| Func<TAccumulate, TSource, TAccumulate> func, | ||
| IEqualityComparer<TKey>? keyComparer = null) where TKey : notnull | ||
| => AggregateBy(source, keySelector, _ => seed, func, keyComparer); |
There was a problem hiding this comment.
I would recommend authoring a separate iterator for this overload in order to avoid incurring a seed delegate + delegate invocation costs.
There was a problem hiding this comment.
Agreed. I have created a dedicated implementation.
| } | ||
| } | ||
|
|
||
| private static Dictionary<TKey, TAccumulate> PopulateDictionary<TSource, TKey, TAccumulate>(IEnumerator<TSource> enumerator, Func<TSource, TKey> keySelector, Func<TKey, TAccumulate> seedSelector, Func<TAccumulate, TSource, TAccumulate> func, IEqualityComparer<TKey>? keyComparer) where TKey : notnull |
There was a problem hiding this comment.
I would recommend making this method a local static, or at least use a name that points to this method being related to AggregateBy.
There was a problem hiding this comment.
Moved to a local static method.
Closes #91533