-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using VS to run host tests when libraries use different config #91873
Conversation
When building the host tests from VS, there are dependencies on projects from the libraries subset. If the libraries are prebuilt with different configuration (typically `Release`) the build in VS breaks because it can't find the project's output. This change modifies the import of generators (which are the problematic projects) to let them override the configuration of the referenced projects. It then adds the ability to set environment based on the `-lc` parameter to the build script when starting VS. Also updates the doc to describe how to use this.
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsWhen building the host tests from VS, there are dependencies on projects from the libraries subset. If the libraries are prebuilt with different configuration (typically This change modifies the import of generators (which are the problematic projects) to let them override the configuration of the referenced projects. It then adds the ability to set environment based on the Also updates the doc to describe how to use this.
|
Co-authored-by: Elinor Fung <elfung@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the ShouldUnsetParentConfigurationAndPlatform
property out of this file, into Directory.Build.props or Directory.Build.targets. It's now already set repo wide as generators.targets gets imported unconditionally but should be moved outside as it affects all types of P2Ps, not just the generator project ones.
Put it in the repo root Directory.Build.props and removed it from the libraries one. |
Thanks a lot Elinor - and sorry I dropped the ball on this one... completely forgot about it. |
When building the host tests from VS, there are dependencies on projects from the libraries subset. If the libraries are prebuilt with different configuration (typically
Release
) the build in VS breaks because it can't find the project's output.This change modifies the import of generators (which are the problematic projects) to let them override the configuration of the referenced projects.
It then adds the ability to set environment based on the
-lc
parameter to the build script when starting VS.Also updates the doc to describe how to use this.