Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Handle enum return type when inlining CreateInstance #91008

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[mono] Handle enum return type when inlining CreateInstance #91008

merged 1 commit into from
Aug 28, 2023
+3 −1

Conversation

uweigand
Copy link
Contributor

Use underlying base type when deciding how to inline a CreateInstance invocation in mini_emit_inst_for_method.

Fixes #90292 (Mono abort causing .NET 8 msbuild regression).

See the linked issue for detailed descriptions of the underlying problem and this fix.

@uweigand
[mono] Handle enum return type when inlining CreateInstance
a73b8ba 
Use underlying base type when deciding how to inline a
CreateInstance invocation in mini_emit_inst_for_method.

Fixes dotnet#90292
(Mono abort causing .NET 8 msbuild regression).
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 23, 2023
@fanyang-mono fanyang-mono self-requested a review August 23, 2023 19:25
@SamMonoRT SamMonoRT added this to the 8.0.0 milestone Aug 23, 2023
@directhex
Copy link
Contributor

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ayakael
Copy link
Contributor

ayakael commented Aug 23, 2023

I can confirm this fix working on s390x musl-libc. Thank you!

@fanyang-mono
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SamMonoRT
Copy link
Member

Thanks @uweigand - Once all validations are complete, @directhex we should backport to release\8.0

This was referenced Aug 24, 2023
Closed
Open
Closed
Open
Closed
Closed
@SamMonoRT
Copy link
Member

@kotlarmilos @fanyang-mono - please help determining if failures in extra-platforms CI lanes are relevant to the changes.

@kotlarmilos
Copy link
Member

Apple mobile failures shouldn't be related.

@directhex
Copy link
Contributor

@kotlarmilos @fanyang-mono - please help determining if failures in extra-platforms CI lanes are relevant to the changes.

That looks like the current expected set of extra platforms failures.

@fanyang-mono
Copy link
Member

fanyang-mono commented Aug 24, 2023 •
edited
Loading

All test failures on extra platform are unrelated to this PR. Thanks for your contribution @uweigand

@fanyang-mono
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5965240020

@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Merged
@fanyang-mono fanyang-mono mentioned this pull request Aug 24, 2023
Closed
3 tasks
@fanyang-mono fanyang-mono added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 24, 2023
@fanyang-mono fanyang-mono merged commit f51b397 into dotnet:main Aug 28, 2023
@uweigand uweigand deleted the mono-createinstance-enum-fix branch August 29, 2023 13:03
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrzVlad BrzVlad BrzVlad approved these changes

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees
No one assigned
Labels
area-Codegen-JIT-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

condition var->opcode == OP_REGOFFSET not met on Mono-based SDK
7 participants
@uweigand @directhex @ayakael @fanyang-mono @SamMonoRT @kotlarmilos @BrzVlad