You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.
Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.
Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.
Issue Details
This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.
Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.
Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.
fixes #90125