Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EnableNativeEventPipe property #90274

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

LakshanF
Copy link
Contributor

@LakshanF LakshanF commented Aug 9, 2023

Early in EventPipe bring up, there was thinking around opt-in and separating native and managed features so as to give flexibility to users. We have come to settle on leaving the option to include to up stack workloads (currently console is opted out, asp.net is opted in) and all managed by a single property, EventSourceSupport. This PR removes the other property, EnableNativeEventPipe, that was an artifact of the earlier thinking.

@ghost
Copy link

ghost commented Aug 9, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Early in EventPipe bring up, there was thinking around opt-in and separating native and managed features so as to give flexibility to users. We have come to settle on leaving the option to include to up stack workloads (currently console is opted out, asp.net is opted in) and all managed by a single property, EventSourceSupport. This PR removes the other property, EnableNativeEventPipe, that was an artifact of the earlier thinking.

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr

Milestone: -

@LakshanF LakshanF merged commit b68382b into dotnet:main Aug 10, 2023
@LakshanF LakshanF deleted the RemoveNativeEventPipeSupprtSwitch branch August 10, 2023 12:16
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants