Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete an unused Span class from object.h #89464

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Delete an unused Span class from object.h #89464

merged 1 commit into from
Jul 25, 2023

Conversation

SingleAccretion
Copy link
Contributor

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 25, 2023
@huoyaoyuan
Copy link
Member

The comment suggests it was intentionally used. What about it's history? Was it introduced with initial implementation of span?

@teo-tsirpanis
Copy link
Contributor

It was introduced in #50814 to speed up reflection and stopped being used in #66357.

@jkotas jkotas marked this pull request as ready for review July 25, 2023 22:40
jkotas
jkotas approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 8aff893 into dotnet:main Jul 25, 2023
@SingleAccretion SingleAccretion deleted the Span-Unused branch July 26, 2023 08:32
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SingleAccretion @huoyaoyuan @teo-tsirpanis @jkotas