-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][mt] enable mono_gc_is_critical_method for MT build #88735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This comment was marked as outdated.
This comment was marked as outdated.
eef0f3f
to
faf10b3
Compare
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 25, 2023
[FAIL] System.Runtime.CompilerServices.UnsafeTests.WriteUnaligned_ByRef_StructManaged
I think this is unrelated to my PR, but I'm not sure. Both exhibitions above are on non-MT build, which this PR doesn't affect. |
That should be fixed already. |
I see #89417 thanks |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Debugger CI failures are unrelated |
lewing
approved these changes
Jul 26, 2023
lambdageek
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75970