Remove comment in ZipFile.Create.cs #86927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dotnet#85491 the stream-based version of the `DoCreateFromDirectory` override copy-pasted comments from the string-based version ```csharp // Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchive ``` The last clause of that comment is not relevant in the stream-based version (the argument is `Stream destination`) so deleted that clause. It's possible that the other comment is also misleading as we test the `compressionLevel ` argument just above (unlike in the `String destinationArchive` version ```csharp // Checking of compressionLevel is passed down to DeflateStream and the IDeflater implementation // as it is a pluggable component that completely encapsulates the meaning of compressionLevel. ```
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsIn #85491 the stream-based version of the // Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchiveThe last clause of that comment is not relevant in the stream-based version (the argument is It's possible that the other comment is also misleading as we test the // Checking of compressionLevel is passed down to DeflateStream and the IDeflater implementation
// as it is a pluggable component that completely encapsulates the meaning of compressionLevel.
|
|
@carlossanlop, care to comment on if they second comment also should be deleted? |
src/libraries/System.IO.Compression.ZipFile/src/System/IO/Compression/ZipFile.Create.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
|
CI failure is unrelated: #82637 |
This was referenced May 31, 2023
|
Thanks @IDisposable ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #85491 the stream-based version of the
DoCreateFromDirectoryoverride copy-pasted comments from the string-based version// Rely on Path.GetFullPath for validation of sourceDirectoryName and destinationArchiveThe last clause of that comment is not relevant in the stream-based version (the argument is
Stream destination) so deleted that clause.It's possible that the other comment is also misleading as we test the
compressionLevelargument just above (unlike in theString destinationArchiveversion)