-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.0] Remove centos 8 images #86477
[7.0] Remove centos 8 images #86477
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
@@ -97,7 +97,7 @@ jobs: | |||
- (Debian.10.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64 | |||
- (Debian.11.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-amd64 | |||
- Ubuntu.1804.Amd64 | |||
- (Centos.8.Amd64)Ubuntu.1604.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix | |||
- (Centos.8.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I don't have a strong opinion about this change - the kernel in 18.04 is much newer and we'd lose some back coverage for test matrix of what's supported. Helix shows the queue existing. Do you have a link to the build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real problem is centos8 is EOL. We haven't tested it in any significant manner. This needs to be closer to:
runtime/eng/pipelines/coreclr/templates/helix-queues-setup.yml
Lines 105 to 109 in 29d485c
- ${{ if eq(parameters.platform, 'linux_x64') }}: | |
- ${{ if eq(variables['System.TeamProject'], 'public') }}: | |
- Ubuntu.1804.Amd64.Open | |
- ${{ if eq(variables['System.TeamProject'], 'internal') }}: | |
- Ubuntu.1804.Amd64 |
It's not great we aren't testing ~16.04 kernels IMO, but at the very least I am OK with removing a couple of these queues. Also, we haven't tested CI in internal for a long time - only PR builds. So they should somewhat mimic PRs on main to have a baseline comparison. This applies for all the entries in this yml - Jeremy had updates this in main, but we never fixed servicing.
@@ -97,7 +97,7 @@ jobs: | |||
- (Debian.10.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64 | |||
- (Debian.11.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-amd64 | |||
- Ubuntu.1804.Amd64 | |||
- (Centos.8.Amd64)Ubuntu.1604.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix | |||
- (Centos.8.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real problem is centos8 is EOL. We haven't tested it in any significant manner. This needs to be closer to:
runtime/eng/pipelines/coreclr/templates/helix-queues-setup.yml
Lines 105 to 109 in 29d485c
- ${{ if eq(parameters.platform, 'linux_x64') }}: | |
- ${{ if eq(variables['System.TeamProject'], 'public') }}: | |
- Ubuntu.1804.Amd64.Open | |
- ${{ if eq(variables['System.TeamProject'], 'internal') }}: | |
- Ubuntu.1804.Amd64 |
It's not great we aren't testing ~16.04 kernels IMO, but at the very least I am OK with removing a couple of these queues. Also, we haven't tested CI in internal for a long time - only PR builds. So they should somewhat mimic PRs on main to have a baseline comparison. This applies for all the entries in this yml - Jeremy had updates this in main, but we never fixed servicing.
We're seeing failures in 7.0 queues due to using non-existent centos 8 images.
Sending directly to the base branch so it gets automatically synced to internal and staging after merging.
cc @jozkee @krwq