Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Remove centos 8 images #86477

Merged
merged 3 commits into from
May 23, 2023

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented May 19, 2023

We're seeing failures in 7.0 queues due to using non-existent centos 8 images.

Sending directly to the base branch so it gets automatically synced to internal and staging after merging.

cc @jozkee @krwq

@ghost
Copy link

ghost commented May 19, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

We're seeing failures in 7.0 queues due to using non-existent 16.04 images.

Sending directly to the base branch so it gets automatically synced to internal and staging after merging.

cc @jozkee @krwq

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@@ -97,7 +97,7 @@ jobs:
- (Debian.10.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64
- (Debian.11.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-amd64
- Ubuntu.1804.Amd64
- (Centos.8.Amd64)Ubuntu.1604.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix
- (Centos.8.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't have a strong opinion about this change - the kernel in 18.04 is much newer and we'd lose some back coverage for test matrix of what's supported. Helix shows the queue existing. Do you have a link to the build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real problem is centos8 is EOL. We haven't tested it in any significant manner. This needs to be closer to:

- ${{ if eq(parameters.platform, 'linux_x64') }}:
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- Ubuntu.1804.Amd64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Ubuntu.1804.Amd64

It's not great we aren't testing ~16.04 kernels IMO, but at the very least I am OK with removing a couple of these queues. Also, we haven't tested CI in internal for a long time - only PR builds. So they should somewhat mimic PRs on main to have a baseline comparison. This applies for all the entries in this yml - Jeremy had updates this in main, but we never fixed servicing.

@@ -97,7 +97,7 @@ jobs:
- (Debian.10.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64
- (Debian.11.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-amd64
- Ubuntu.1804.Amd64
- (Centos.8.Amd64)Ubuntu.1604.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix
- (Centos.8.Amd64)Ubuntu.1804.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-helix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real problem is centos8 is EOL. We haven't tested it in any significant manner. This needs to be closer to:

- ${{ if eq(parameters.platform, 'linux_x64') }}:
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
- Ubuntu.1804.Amd64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Ubuntu.1804.Amd64

It's not great we aren't testing ~16.04 kernels IMO, but at the very least I am OK with removing a couple of these queues. Also, we haven't tested CI in internal for a long time - only PR builds. So they should somewhat mimic PRs on main to have a baseline comparison. This applies for all the entries in this yml - Jeremy had updates this in main, but we never fixed servicing.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 19, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label May 19, 2023
@carlossanlop carlossanlop requested a review from hoyosjs May 19, 2023 23:34
@carlossanlop carlossanlop changed the title [7.0] Bump Ubuntu 16.04 images to 18.04 [7.0] Remove centos 8 images May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants