Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix official build after removing win-arm runtime build #86074

Merged
merged 1 commit into from
May 11, 2023

Conversation

BruceForstall
Copy link
Member

win-arm CI builds were removed with #85947

Hopefully fixes #86073

@BruceForstall
Copy link
Member Author

I don't know how the mono stuff works, but this removes obvious references to win-arm.

There are a few more in:

Microsoft.NET.Workload.Mono.Toolchain.net6.Manifest\WorkloadManifest.json.in
Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest\WorkloadManifest.json.in

but it makes me nervous to touch something that on the surface appears to be related to servicing.

@ghost
Copy link

ghost commented May 10, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

win-arm CI builds were removed with #85947

Hopefully fixes #86073

Author: BruceForstall
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@BruceForstall
Copy link
Member Author

Btw, I'm not sure how to test the official build, except to merge and wait. Since it's currently broken, maybe that's the right strategy?

Suggestions?

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - at least it's what I would have tried. Would still be good to get mono folks to review. Thanks!

@BruceForstall BruceForstall requested a review from akoeplinger May 10, 2023 22:12
@BruceForstall BruceForstall merged commit a951e99 into dotnet:main May 11, 2023
@BruceForstall BruceForstall deleted the FixOfficialBuild branch May 11, 2023 04:41
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official build fails due to missing windows_arm job
3 participants