[release/6.0-staging] define UNW_AARCH64 aliases conditionally #84873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschwMSFT
approved these changes
May 2, 2023
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of: #84591
Customer Impact
Fixes a build break with the new macOS SDK.
The libunwind.h that comes with the new MacOS SDK now has the enum for things like
UNW_AARCH64_X19, so the workaround for not having those constants now causes build failures due to duplicate definition.runtime/src/coreclr/pal/src/exception/seh-unwind.cpp
Line 58 in 4ece8f0
Without taking build dependency on the newest SDK, we need to apply the workaround conditionally.
Since this is an enum (not a define), we can't do simple
#ifndefand need to do a configure test.Testing
Risk