Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix x64 macOS and Linux managed debugging #84655

Merged
merged 4 commits into from
Apr 15, 2023
Merged

Fix x64 macOS and Linux managed debugging #84655

merged 4 commits into from
Apr 15, 2023

Conversation

tommcdon
Copy link
Member

A recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging.

Fixes #84466

@tommcdon tommcdon requested a review from mikem8361 April 11, 2023 21:22
@ghost ghost assigned tommcdon Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

A recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging.

Fixes #84466

Author: tommcdon
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: -

@tommcdon tommcdon added this to the 8.0.0 milestone Apr 11, 2023
@tommcdon tommcdon marked this pull request as draft April 11, 2023 21:22
@tommcdon tommcdon requested a review from hoyosjs April 11, 2023 21:22
@tannergooding
Copy link
Member

This was probably caused by my thread suspend/restore changes, sorry!

Is there anything we can do to catch such breaks in the future?

@tommcdon
Copy link
Member Author

Hi @tannergooding! No worries! We have tests in the dotnet/diagnostics repo that would catch this issue but there were unrelated problems that was preventing a runtime update. Our plan/thinking to address this in the future is to add some static asserts to the code that would at least alert folks to the debugger's dependency on context sizes.

@mikem8361 mikem8361 force-pushed the dev/tommcdon/fixx64macdbg branch from 38d6b34 to 24ec334 Compare April 14, 2023 03:50
@mikem8361 mikem8361 force-pushed the dev/tommcdon/fixx64macdbg branch from 24ec334 to faefa50 Compare April 14, 2023 03:51
@build-analysis build-analysis bot mentioned this pull request Apr 14, 2023
Closed
@mikem8361 mikem8361 marked this pull request as ready for review April 14, 2023 16:39
tommcdon
tommcdon commented Apr 14, 2023
View reviewed changes
Copy link
Member Author

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for your consideration otherwise the changes look good to me! I would approve the PR but I am unable to as I am the owner of it :).

@mikem8361 mikem8361 self-assigned this Apr 14, 2023
@mikem8361 mikem8361 merged commit 49af07c into dotnet:main Apr 15, 2023
@clamp03 clamp03 mentioned this pull request Apr 17, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikem8361 mikem8361 mikem8361 approved these changes

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@mikem8361 mikem8361

@tommcdon tommcdon

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[NETSDKE2E] With .NET 8.0 Preview4, debugging does not work normally on Mac X64
3 participants
@tommcdon @tannergooding @mikem8361