Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ThunkGenerator #84390

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fix ThunkGenerator #84390

merged 2 commits into from
Apr 6, 2023

Conversation

MichalPetryka
Copy link
Contributor

Fixes:

 error CA1859: Change type of parameter 'tr' from 'System.IO.TextReader' to 'System.IO.StreamReader' for improved performance
 error CA1859: Change return type of method 'ParseInput' from 'System.Collections.Generic.IEnumerable<Thunkerator.FunctionDecl>' to 'System.Collections.ObjectModel.ReadOnlyCollection<Thunkerator.FunctionDecl>' for improved performance

@MichalPetryka
Fix ThunkGenerator
f5790dd 
Fixes:
```
 error CA1859: Change type of parameter 'tr' from 'System.IO.TextReader' to 'System.IO.StreamReader' for improved performance
 error CA1859: Change return type of method 'ParseInput' from 'System.Collections.Generic.IEnumerable<Thunkerator.FunctionDecl>' to 'System.Collections.ObjectModel.ReadOnlyCollection<Thunkerator.FunctionDecl>' for improved performance
```
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 6, 2023
MichalStrehovsky
MichalStrehovsky approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@EgorBo
Copy link
Member

EgorBo commented Apr 6, 2023 •
edited
Loading

till the next build break (when new analyzers are added), it needs to be executed as part of CI - it's not the first time it's fixed separately because of that

jkotas
jkotas approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit f0fbcc2 into dotnet:main Apr 6, 2023
@EgorBo EgorBo mentioned this pull request Apr 6, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalPetryka @EgorBo @jkotas @MichalStrehovsky