Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Clean up the delegate ctor code. #83288

Merged
merged 4 commits into from
Mar 13, 2023
Merged

[mono] Clean up the delegate ctor code. #83288

merged 4 commits into from
Mar 13, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Mar 11, 2023

  • Merge the virtual and non-virtual cases.
  • Name variables etc. delegate info instead of delegate trampoline.
  • Avoid setting the del->is_virtual field if its FALSE.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned vargaz Mar 11, 2023
@vargaz vargaz force-pushed the del-cleanup-2 branch 3 times, most recently from 4eeca08 to 5a35dc1 Compare March 11, 2023 00:52
This was referenced Mar 11, 2023
Closed
Closed
Closed
@vargaz vargaz force-pushed the del-cleanup-2 branch 2 times, most recently from 180c4d2 to 831fb0b Compare March 11, 2023 17:30
@vargaz vargaz marked this pull request as ready for review March 11, 2023 17:42
@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

It would be easier to review the commits one-by-one instead of the final diff.

@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Mar 11, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 12, 2023
Closed
Closed
vargaz added 4 commits March 12, 2023 06:25
@vargaz
[mono] Clean up the delegate ctor code.
e55aa41 
* Merge the virtual and non-virtual cases.
* Reorder the code in handle_delegate_ctor () to reduce the llvm_only conditionals.
* Name variables etc. delegate info instead of delegate trampoline.
* Avoid setting the del->is_virtual field if its FALSE.
@vargaz
Remove some code which is already done by mono_resolve_patch_target_e…
af51981 
…xt ().
@vargaz
Remove some dead code.
3a40300
@vargaz
Unify the virtual/non-virtual case for llvmonly as well.
320236b
@vargaz
Copy link
Contributor Author

vargaz commented Mar 12, 2023

Failures are unrelated.

@vargaz vargaz merged commit bbc7e06 into dotnet:main Mar 13, 2023
@vargaz vargaz deleted the del-cleanup-2 branch March 13, 2023 13:43
@kotlarmilos kotlarmilos mentioned this pull request Mar 14, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrzVlad BrzVlad BrzVlad approved these changes

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos kotlarmilos is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@vargaz vargaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @BrzVlad