Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] code cleanup #83210

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[browser] code cleanup #83210

merged 1 commit into from
Mar 10, 2023

Conversation

pavelsavara
Copy link
Member

Yet another cleanup split from #82049

  • drop loaded_assets
  • drop mono_wasm_load_icu_data from wasm imports
  • drop mono_wasm_load_runtime_done
  • drop noisy console.debug
  • move instantiateWasmPThreadWorkerPool after mono is started
  • move replace_linker_placeholders
  • move SpecialFolder.CommonApplicationData creation to postRunAsync
  • move bindings_init() out to onRuntimeInitializedAsync
  • unified body of mono_wasm_before_user_runtime_initialized and _apply_configuration_from_args

@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 9, 2023
@pavelsavara pavelsavara requested review from kg, lambdageek and maraf March 9, 2023 16:06
@pavelsavara pavelsavara self-assigned this Mar 9, 2023
@ghost
Copy link

ghost commented Mar 9, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Yet another cleanup split from #82049

  • drop loaded_assets
  • drop mono_wasm_load_icu_data from wasm imports
  • drop mono_wasm_load_runtime_done
  • drop noisy console.debug
  • move instantiateWasmPThreadWorkerPool after mono is started
  • move replace_linker_placeholders
  • move SpecialFolder.CommonApplicationData creation to postRunAsync
  • move bindings_init() out to onRuntimeInitializedAsync
  • unified body of mono_wasm_before_user_runtime_initialized and _apply_configuration_from_args
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Mar 9, 2023
Closed
@pavelsavara pavelsavara marked this pull request as ready for review March 9, 2023 19:44
@pavelsavara pavelsavara requested a review from lewing as a code owner March 9, 2023 19:44
maraf
maraf approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara
Copy link
Member Author

There is DebuggerTests.EvaluateOnCallFrameTests timeout on runtime-wasm CI pipiline with multi-threaded build. Log

I believe this is fragile test, not issue of the current PR. Merging.

cc @thaystg , please let me know if I was wrong about it.

@pavelsavara pavelsavara merged commit a923c64 into dotnet:main Mar 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2023
@pavelsavara pavelsavara deleted the browser_memory_snapshot4 branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg Awaiting requested review from kg

@lambdageek lambdageek Awaiting requested review from lambdageek

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf