Fix unitialized local in impCastClassOrIsInstToTree #82348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you also remove it from issues.targets? runtime/src/tests/issues.targets Lines 1327 to 1329 in ce719aa |
|
@jakobbotsch @dotnet/jit-contrib PTAL, simple fix, zero diffs (fixes NAOT) |
jakobbotsch
approved these changes
Feb 20, 2023
|
Failure is #82397 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82071
op2is supposed to be a class handle which is saved to a local via COMMA (importer-level CSE). There was a case related to getExactClasses where that COMMA didn't present in the tree.Asm diff for
CastToGenericInterfacein #82071: https://www.diffchecker.com/lV4PCEeJ/