Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] Calling JS functions from workers + config loading #81273

Merged
merged 8 commits into from
Jan 31, 2023
Merged

[browser][MT] Calling JS functions from workers + config loading #81273

merged 8 commits into from
Jan 31, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 27, 2023 •
edited
Loading

  • fix adding mono JS functions into wasm imports directly + remove workaround
  • create one-off message port to exchange mono config very early
  • await the mono config before resolving the topmost dotnet.js promise
  • fix forwarding console to WS

Fixes #81268

@pavelsavara pavelsavara added this to the 8.0.0 milestone Jan 27, 2023
@pavelsavara pavelsavara self-assigned this Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #81268

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara mentioned this pull request Jan 27, 2023
Closed
lambdageek
lambdageek reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thanks for doing it so quickly

@pavelsavara pavelsavara changed the title [browser][MT] fix calling JS functions from workers [browser][MT] Calling JS functions from workers + config loading Jan 30, 2023
@pavelsavara pavelsavara requested a review from kg January 30, 2023 14:23
@pavelsavara pavelsavara marked this pull request as ready for review January 30, 2023 14:23
@pavelsavara pavelsavara requested a review from lewing as a code owner January 30, 2023 14:23
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

to be merged only after preview1 snap

@lambdageek lambdageek added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 30, 2023
@pavelsavara pavelsavara requested a review from maraf January 30, 2023 15:40
@build-analysis build-analysis bot mentioned this pull request Jan 30, 2023
Open
5 tasks
@pavelsavara pavelsavara removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 31, 2023
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit e831dab into dotnet:main Jan 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2023
@pavelsavara pavelsavara deleted the browser_mt_jsfunctions branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf left review comments

@lambdageek lambdageek lambdageek approved these changes

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[browser][MT] fix calling JS functions from workers
3 participants
@pavelsavara @lambdageek @maraf