[release/7.0] Fix multiple dumps from being generated #80708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: #78956 After a core dump is generated because of a unhandled managed exception abort() is called but a SIGSEGV is generated in libpthread.so which is caught by the runtime and a second core dump is generated. The fix is to uninstall/uninitialize all the signal handlers, not just SIGABORT.
hoyosjs
approved these changes
Jan 16, 2023
jeffschwMSFT
approved these changes
Jan 17, 2023
|
Approved by Tactics for 7.0.3. |
cc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #80474 to release/7.0
/cc @mikem8361
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Diagnostics/createdump tests ran locally.
Risk
Low. Affects only crash dump generation on Linux/MacOS.